Validate BCs for equivalent but distinct matrix spaces#4255
Open
masaqif wants to merge 1 commit into
Open
Conversation
masaqif
force-pushed
the
fix-petrov-galerkin-bc-validation
branch
from
c004515 to
00a158a
Compare
masaqif
changed the title
Author
|
I narrowed the validation after CI showed that general different-degree and submesh Petrov-Galerkin assembly with BCs is supported and already covered by tests. The current check now targets only equivalent same-mesh spaces represented by distinct FunctionSpace objects, and it is bypassed for recursive MatNest sub-block assembly so existing block formulations are not rejected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject Dirichlet boundary conditions for standalone matrix assembly when the test and trial spaces use equivalent elements on the same mesh but are distinct function space objects. In this case BC row/column zeroing can happen without a diagonal insertion because the spaces are not identical.\n\nThe check is skipped for recursive PETSc MatNest sub-block assembly so existing block and mixed formulations continue to work.\n\nAdds regression coverage for both MatrixCSR and PETSc assembly.\n\nSplit out from #4249 per maintainer request.